-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update Storybook to v8 #234
base: main
Are you sure you want to change the base?
Conversation
"@storybook/addon-links", | ||
"@storybook/addon-essentials", | ||
"@storybook/addon-interactions", | ||
"@storybook/addon-mdx-gfm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this add on will be likely be removed in a future version. Is there a strong reason for including this vs following the recommended instructions? https://www.npmjs.com/package/@storybook/addon-mdx-gfm
@CodiumAI-Agent /review |
PR Review 🔍
Code feedback:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot checked most of the default stories. No breaking changes were found.
Lg 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting a note here that some portion of this update may need to be reverted or reconciled now that #334 has been merged.
Overview
Updates the storybook install to the new version, v8, and updates stories to the new format. This is a prerequisite for implementing the design-system, as we want to use the new storybook inheritance and visual testing suite.
Security
REMINDER: All file contents are public.
Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.
Checklist
Testing
Documentation
Consider "Squash and merge" as needed to keep the commit history reasonable on
main
.Reviewers
Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including: