Remove Identity Tests for Default Testing #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates the exceedingly slow testing for Identity into an e2e test set so that we don't have to wait on very slow ci/cd. This should be used before any release.
jeremytwfortune
added
enhancement
kneumei
approved these changes
Apr 30, 2024
typescript/vitest.config.js
Outdated
| @@ -4,5 +4,6 @@ export default defineConfig({ | |||
| test: { | |||
| testTimeout: 300000, | |||
| hookTimeout: 300000, | |||
There was a problem hiding this comment.
do you need these long timeouts on unit tests?
There was a problem hiding this comment.
Probably not. They could be reduced a bit.
kneumei
approved these changes
Apr 30, 2024
kneumei
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Testing the Identity API for every PR has become untenable. The small instance that we have allocated for this purpose just can't handle the volume of mostly-duplicate identifiers, resulting in a ton of spurious workflow errors.
This PR categorizes tests into default and e2e. There is now also an issue template for releasing a new tag and a checklist on that template to be sure that you have run the e2e tests prior to tagging.
Security
REMINDER: All file contents are public.
While it would be nice to test against the Identity API for all changes, no code should be released with these changes prior to going through e2e.
Reviewers