Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store originalFont for CEVRK1Label to make updateAppearance idempotent #148

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

eschramm
Copy link

Fixes https://github.com/CareEvolution/MyDataHelps-iOS/issues/1323.

Using the same pattern as adopted when parsing Markdown, we'll hold onto the original value so if called multiple times we are having the same result.

Testing

  1. Configure test device to have text size configured at the size below (Settings > Accessibility > Display & Text Size > Larger Text) - 2 up from standard.
  2. Run the survey from https://github.com/CareEvolution/MyDataHelps-iOS/issues/1322 and pay special attention that the footnote in the ConsentPII_PIIContactInformation step (where you are prompted for an address).
  3. Verify the footnote hasn't creeped up inside to something seen in the screenshots for https://github.com/CareEvolution/MyDataHelps-iOS/issues/1323.

Simulator Screenshot - iPhone 15 Pro - 2024-08-26 at 11 10 59

Copy link
Member

@mmertsock mmertsock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested successfully 🚢

@eschramm eschramm merged commit cb7ba59 into CEVRelease-2.x Sep 3, 2024
1 check passed
@eschramm eschramm deleted the eschramm/fixMDFooter branch September 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants