Make NSAssert simply an if clause to allow mismatched defaultValue #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/CareEvolution/MyDataHelps-iOS/issues/1314.
While the fix is relatively simple, following the logic upstream to understand risk of regression bugs is not. Regardless, I feel confident this fixes the issue by de-escalating a mismatched defaultValue of an ORK[1]AnswerFormat (which is technically not stored there, but we pluck them out on deserialization) from an
NSAssert
to a simple check. I ran though the UITests as well which does a battery of tests on basic RK functionality.Testing
Verify the following survey doesn't crash on iOS. It has a defaultValue ("garbage") which doesn't match any of the TextChoice values.
Also regression testing of survey functionality of iOS would be helpful, in particular the following: