Update req dependency to allow 0.5.x #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to maintain compatibility with recent releases of other gems (e.g. swoosh), update the req dependency to 0.5.x.
|
Also, this doesn't seem to be passing. Can you please make whatever additional changes are required to get it to work on |
Co-authored-by: Ben Wilson <[email protected]>
Yes, I'll take a look at that now. |
It looks like the failure occurs when testing with elixir 1.12, because newer versions req only support 1.13 and above. Specifically, the use of `Keyword.validate!/2 is what causes the error (because it's not available in elixir 1.12). I will update the CI matrix to account for the ineligible version. |
Change CI and mix.exs to indicate that elixir versions 1.13 and above are now supported (due to the req version update).
benwilson512
approved these changes
Jun 13, 2024
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to maintain compatibility with recent releases of other gems (e.g. swoosh), update the req dependency to allow 0.5.x.