Merge Icv3 changes #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… group, an use full reference for Hyperlinkname. Also set ssl_verify to false
CarliJoy
commented
Feb 18, 2023
| "--ignore-project", | ||
| "-ip", | ||
| dest="ignore_project", | ||
| help="Ignore Gitlab Issue with a match to the projec id", |
There was a problem hiding this comment.
Suggested change
| help="Ignore Gitlab Issue with a match to the projec id", | |
| help="Ignore Gitlab Issue with a match to the project id", |
| @@ -150,14 +163,17 @@ def has_not_label(issue: Issue, label: str) -> bool: | |||
|
|
|||
| Returns: True if to include the label | |||
| """ | |||
| global Ignore_project_id | |||
There was a problem hiding this comment.
Global are an anti pattern
| - Add Actual Start from gitlab created_at | ||
| - Add option for ignoring given project id within group | ||
| - Replaced Hyperlinkname with gitlab full reference | ||
| - Access Gitlab with ssl_verify set to false |
There was a problem hiding this comment.
This shouldn't be the default but only an option, as it is a security risk.
| @@ -2,6 +2,15 @@ | |||
| Changelog | |||
| ========= | |||
|
|
|||
| Version 0.0.7 | |||
| ============= | |||
| - Removed Notes | |||
Comment on lines
+281
to
284
| return Gitlab(server, ssl_verify=False) | ||
| else: | ||
| return Gitlab(server, private_token=personal_token) | ||
| return Gitlab(server, private_token=personal_token, ssl_verify=False) | ||
|
|
There was a problem hiding this comment.
As written in before: Don't do this by default. You can add an option that disables this changes so.
| @@ -129,7 +129,7 @@ def update_task_with_issue_data( | |||
| type_setter = task_type_setter(issue) | |||
| type_setter.set_task_type_before_sync(task, is_add) | |||
| task.name = issue.title | |||
| task.notes = issue.description | |||
| #task.notes = issue.description | |||
There was a problem hiding this comment.
Why did you remove this?
Make this an option instead. So users can disable the functionality.
|
And of course you need to run pre-commit :-) |
|
@lcv3 would you be able to work on the issue? I don't posses MS Projekt anymore, so I would need your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.