AI Thinker: Fix volume levels #68
Conversation
| @@ -346,6 +346,10 @@ es8388_init (audio_hal_codec_config_t *cfg) | |||
| 0x80); // set internal ADC and DAC use the same LRCK | |||
| // clock, ADC LRCK as internal LRCK | |||
| res |= es_write_reg (ES8388_ADDR, ES8388_DACCONTROL23, 0x00); // vroi=0 | |||
| res |= es_write_reg (ES8388_ADDR, ES8388_DACCONTROL24, 0x1E); // Set L1 R1 L2 R2 volume. 0x00: -30dB, 0x1E: 0dB, 0x21: 3dB | |||
There was a problem hiding this comment.
How does this impact other boards using the same codec (lyrat v4.3, etc.)?
There was a problem hiding this comment.
They probably should be fine with this but I'm not sure since I don't have one.
There was a problem hiding this comment.
Ok I'll test this and compare as I've got 2
|
fyi: With this settings my Board is way to loud. I had to adapt this like written in this PR #67 (comment) |
|
Ok thank you, I will consider this in #69 |
|
Just some more feedback: I am using a LyraT 4.3 and this commit really dropped the volume on mine (I have speakers wired directly to the board which has a small on-board amplifier). Very quiet. I wound up reverting to the pre-commit code for this reason. (Edit for clarity: I do/did not have the bottom half range problem that op did, for this board) |
|
So we should differentiate between boards in the driver in your opinion? Could you please open an issue on this so I don't forget about it? |
Follow up to #67 . I found the entire bottom half of the range is completely inaudible. This adjusts the range to only the top 50% of what it used to be.
The changes to DACCONTROL24-27 appear to not be important to change.