Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/Zklend_models #273

Merged
merged 6 commits into from
Nov 1, 2024
Merged

feat/Zklend_models #273

merged 6 commits into from
Nov 1, 2024

Conversation

binayak9932
Copy link
Contributor

@binayak9932 binayak9932 commented Oct 31, 2024 •
edited
Loading

Issue #272

  • Created new models for missing events hereInherited from EventBaseModel
    Created new models for next events:
  • RepaymentEventData
  • DepositEventData
  • BorrowingEventData
  • WithdrawalEventData
  • CollateralEnabledDisabledEventData
  • Generated migration file
  • Added changes in the older migration beacuse there was an error during migration "Alembic was attempting to drop an index, ix_notification_email, which didnt exist in the database." so i wrapped it in a conditional check to first check if the notification table exists before attempting to drop the index.

@binayak9932
Copy link
Contributor Author

@djeck1432 Please review

@djeck1432 djeck1432 self-requested a review October 31, 2024 19:24
@djeck1432 djeck1432 linked an issue Oct 31, 2024 that may be closed by this pull request
Add missing models for saving ZkLend events data into db #272
Closed
djeck1432
djeck1432 requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rework migration file after your changes
  2. Remove poetry.lock if you didn't do any changes in pyproject.toml

apps/data_handler/db/models/zklend_events.py Outdated Show resolved Hide resolved
apps/data_handler/db/models/zklend_events.py Outdated Show resolved Hide resolved
apps/data_handler/db/models/zklend_events.py Outdated Show resolved Hide resolved
apps/data_handler/db/models/zklend_events.py Outdated Show resolved Hide resolved
apps/data_handler/db/models/zklend_events.py Outdated Show resolved Hide resolved
@binayak9932
Copy link
Contributor Author

binayak9932 commented Oct 31, 2024 •
edited
Loading

@djeck1432 Please review did the requested Changes

@binayak9932 binayak9932 requested a review from djeck1432 October 31, 2024 20:42
@binayak9932
Copy link
Contributor Author

  1. Rework migration file after your changes
  2. Remove poetry.lock if you didn't do any changes in pyproject.toml

Done

djeck1432
djeck1432 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good job

@djeck1432 djeck1432 merged commit fd94afd into CarmineOptions:master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees

@binayak9932 binayak9932

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing models for saving ZkLend events data into db
2 participants
@binayak9932 @djeck1432