feat: standardize event data for mint and burn none-interest #305
Conversation
| """ | ||
| sender: str | ||
| recipient: str | ||
| raw_amount: str |
There was a problem hiding this comment.
raw_amount Should be Decimal
| face_amount (str): The face amount being burned | ||
| """ | ||
| user: str | ||
| face_amount: str |
There was a problem hiding this comment.
Add spacing between class variable and method
| face_amount (str): The face amount being burned | ||
| """ | ||
| user: str | ||
| face_amount: str |
There was a problem hiding this comment.
Face_amount should be decimal
| else: | ||
| raise ValueError("Event = {} has an unexpected structure.".format(event)) | ||
| if self.ZERO_ADDRESS in {sender, recipient}: | ||
| if self.ZERO_ADDRESS in {sender, recipient} | self.ZERO_ADDRESS in {parsed_event.sender, parsed_event.recipient}: |
There was a problem hiding this comment.
why diid you change this code?
| @@ -398,6 +399,26 @@ def process_non_interest_bearing_collateral_mint_event(self, event: pd.Series) - | |||
| ) | |||
| ) | |||
|
|
|||
| if parsed_event.sender != self.DEFERRED_BATCH_CALL_ADAPTER_ADDRESS: | |||
There was a problem hiding this comment.
You have duplicated code, please remove it
|
@Tzienom I'm not sure that you can manage with this task, so easy task and so many issues |
|
i will fix it before end of day |
| @@ -372,6 +372,7 @@ def process_non_interest_bearing_collateral_mint_event(self, event: pd.Series) - | |||
| sender = add_leading_zeros(event["data"][0]) | |||
There was a problem hiding this comment.
why you didn't remove these fields?
| @@ -500,26 +502,40 @@ def process_non_interest_bearing_collateral_burn_event(self, event: pd.Series) - | |||
| # Example: | |||
| # https://starkscan.co/event/0x00744177ee88dd3d96dda1784e2dff50f0c989b7fd48755bc42972af2e951dd6_1. | |||
| user = event["data"][0] | |||
| if user == self.IGNORE_USER: | |||
| parsed_event = NostraDataParser.parse_non_interest_bearing_collateral_burn_event(event["data"]) | |||
| if user == self.IGNORE_USER | parsed_event == self.IGNORE_USER: | |||
There was a problem hiding this comment.
why did you change this code?
and why parsed event return only user data here if it should return more values?
| ) | ||
| for token in NOSTRA_ALPHA_SPECIFIC_TOKEN_SETTINGS | ||
| } | ||
| if user == self.verbose_user | parsed_event.user == self.verbose_user: |
|
@Tzienom Please fix your comments within next hours, otherwise you will be unassigned, this task blocking us to go further |
|
completing shortly |
|
@djeck1432 my branch is currently uptodate with master already |
No description provided.