Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: complete serializers reorganization #317

Closed

Conversation

akintewe
Copy link
Contributor

Changes Made

  • Created new serializers folder in apps/data_handler/handler_tools/data_parser/
  • Separated serializers into two files based on their domain:
  • nostra.py: Contains Nostra-related serializers
  • zklend.py: Contains zkLend-related serializers
  • Created __init__.py with proper imports and exports from both files

Closes #307

@djeck1432 djeck1432 self-requested a review November 24, 2024 20:54
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, run black command for your files
Remove this file [get-pip.py](https://github.com/CarmineOptions/derisk-research/pull/317/files#diff-333f925f52b4ce75f65b3e49a8a71acd851ab66561480309d9e34de7a888a452)

@akintewe akintewe force-pushed the feature/reorganize-serializers branch from 8573b7e to 6f4248d Compare November 24, 2024 21:54
@akintewe
Copy link
Contributor Author

akintewe commented Nov 24, 2024

Please, run black command for your files Remove this file [get-pip.py](https://github.com/CarmineOptions/derisk-research/pull/317/files#diff-333f925f52b4ce75f65b3e49a8a71acd851ab66561480309d9e34de7a888a452)

Done Please review

Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, close this pr and create new one, I asked you to run only for files which you have changed, you ran it for all of them. I would be hard to do code review for you code.

@akintewe
Copy link
Contributor Author

Please, close this pr and create new one, I asked you to run only for files which you have changed, you ran it for all of them. I would be hard to do code review for you code.

oh my bad, got it, ill do that now

@akintewe akintewe closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all events models into separated files
2 participants