Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add missing events to nostra transform events #348

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Feature/add missing events to nostra transform events #348

merged 4 commits into from
Nov 29, 2024

Conversation

MrRoudyk
Copy link
Contributor

Closes #338

@djeck1432 @MrRoudyk
Merge pull request CarmineOptions#342 from AdejareSamad/feat/create-g…
d074d92 
…et-protocol-interface

feat: create new interface for get_protocols
@djeck1432 djeck1432 self-requested a review November 28, 2024 20:44
djeck1432
djeck1432 requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I don't understand why did you rename models name and tables
  2. Please run also generating migration file

apps/data_handler/handler_tools/data_parser/serializers/nostra.py Show resolved Hide resolved
apps/data_handler/handler_tools/data_parser/serializers/nostra.py Show resolved Hide resolved
apps/data_handler/db/crud.py Outdated Show resolved Hide resolved
@MrRoudyk
Copy link
Contributor Author

MrRoudyk commented Nov 28, 2024 •
edited
Loading

  1. I don't understand why did you rename models name and tables

But I didn't rename models name and tables. I just added new methods and sorted them alphabetically

@djeck1432
Copy link
Collaborator

@MrRoudyk Maybe you resolved conflict in wrong way, let me check

@djeck1432
Copy link
Collaborator

@MrRoudyk okay, it's just github display in a wrong way, checked all looks good regarding models

@MrRoudyk
feat: Add missing events to nostra transform_events
f892a73
@MrRoudyk
Merge remote-tracking branch 'upstream/master' into feature/add-missi…
5cdbe3e 
…ng-events-to-nostra-transform_events

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@MrRoudyk
feat: Add missing events to nostra transform_events
02ef2a7
@MrRoudyk MrRoudyk force-pushed the feature/add-missing-events-to-nostra-transform_events branch from 5215e0f to 02ef2a7 Compare November 29, 2024 09:28
@MrRoudyk
Copy link
Contributor Author

  1. Please run also generating migration file

I’m still working on generating the migration file following the instructions but haven’t succeeded yet

@MrRoudyk
Copy link
Contributor Author

  1. Please run also generating migration file

I’m still working on generating the migration file following the instructions but haven’t succeeded yet

Oh, I realized that since there weren't any actual changes to the models or table names, we don't need to create a migration file.
@djeck1432 let me know if that works for you or if there's anything else I should do

@djeck1432
Copy link
Collaborator

@MrRoudyk https://github.com/CarmineOptions/derisk-research/pull/349/files
try to run this script for migration

@djeck1432
Copy link
Collaborator

@MrRoudyk Just checked, looks good

djeck1432
djeck1432 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit a4f9b70 into CarmineOptions:master Nov 29, 2024
@MrRoudyk
Copy link
Contributor Author

@MrRoudyk https://github.com/CarmineOptions/derisk-research/pull/349/files try to run this script for migration

Yes, I ran the script and it worked (I just had to replace poetry shell with poetry run). The migration file is here: https://github.com/MrRoudyk/derisk-research/blob/feature/add-missing-events-to-nostra-transform_events/apps/data_handler/migrations/versions/cc5f9168f89a_add_missing_events_to_nostra_transform_.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataHandler] Add missing events to nostra transform_events
2 participants
@MrRoudyk @djeck1432