Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: migrations script #349

Merged
merged 11 commits into from
Nov 29, 2024
Merged

feature: migrations script #349

merged 11 commits into from
Nov 29, 2024

Conversation

vitaliypopel
Copy link
Contributor

Has been created bash script for autogenerating new migration in one command

@djeck1432 djeck1432 self-requested a review November 28, 2024 19:57
@djeck1432 djeck1432 linked an issue Nov 28, 2024 that may be closed by this pull request
[Data_handler] Create bash script for running generating migration in one command #336
Closed
djeck1432
djeck1432 requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Set up and run up db using docker
  2. install dependencies using poetry install
  3. then activate env poetry shell
  4. and only then run all your command [without last step] applying migration is not needed ]

djeck1432
djeck1432 requested changes Nov 29, 2024
View reviewed changes
apps/data_handler/migrate.sh Outdated Show resolved Hide resolved
djeck1432
djeck1432 requested changes Nov 29, 2024
View reviewed changes
apps/data_handler/migrate.sh Outdated Show resolved Hide resolved
apps/data_handler/migrate.sh Outdated Show resolved Hide resolved
djeck1432
djeck1432 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit 8764daf into CarmineOptions:master Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data_handler] Create bash script for running generating migration in one command
2 participants
@vitaliypopel @djeck1432