Add default proposal parameters and custom proposal configuration #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to fix tests, but otherwise ready for review |
scobi7
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Logic looks good. Im unfamiliar with the small quorum values that are hard coded so just ensuring those are good and can be left like that should be okay. (like in get quorum or the asserts in set_default_proposal_params)
Also maybe emitting an event for when parameters of proposals are changed may be a good idea.
src/proposals.cairo
Outdated
| @@ -554,5 +579,15 @@ mod proposals { | |||
| self.custom_proposal_type.write(idx, config); | |||
| idx | |||
| } | |||
|
|
|||
| fn set_default_proposal_params(ref self: ComponentState<TContractState>, quorum: u32, proposal_voting_seconds: u32) { | |||
There was a problem hiding this comment.
Looks good for proposal parameter configurations. Only potential suggestion is maybe emitting an event for changes in proposal parameters?
There was a problem hiding this comment.
No strong opinion on that, but don't see a reason to consume that event, so not adding
Was broken because I deployed the treasury contract on Sepolia.
tensojka
added a commit
that referenced
this pull request
Aug 26, 2024
tensojka
added a commit
that referenced
this pull request
Aug 26, 2024
* Add proposal that updates default prop params (see #127) * Add display of generic proposal * Fix dependencies, add eslint CI * Update CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes quorum and proposal voting time to come from a storage variable and thus be updatable. Also adds support for custom proposals that have a shorter voting time.