Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from MusicPlayerDaemon:master #20

Merged
merged 13 commits into from
Jan 28, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 28, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update build dependencies to their latest versions, including fmt, sqlite3, libnpupnp, libmicrohttpd, and libpipewire.

Build:

  • Update the meson build configuration to include libnpupnp and libmicrohttpd.

CI:

  • Update the ccache action in the build workflow to v1.2.

@pull pull bot added the ⤵️ pull label Jan 28, 2025
@pull pull bot merged commit 177ffde into CartoonFan:master Jan 28, 2025
Copy link

sourcery-ai bot commented Jan 28, 2025

Reviewer's Guide by Sourcery

This pull request updates the build system to include new dependencies, adjusts compiler warning levels, and updates the ccache action version. It also includes some minor changes to the NEWS file and subproject files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new dependencies and set their default library to static.
  • Added libmicrohttpd dependency.
  • Added libnpupnp dependency.
  • Set libmicrohttpd default library to static.
  • Set libnpupnp default library to static.
meson.build
Disabled warnings for new dependencies.
  • Set libmicrohttpd warning level to 0.
  • Set libnpupnp warning level to 0.
meson.build
Updated pipewire dependency to include type.
  • Added include_type: 'system' to pipewire dependency.
src/lib/pipewire/meson.build
Updated ccache action version.
  • Updated ccache action to v1.2.
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

guardrails bot commented Jan 28, 2025

⚠️ We detected 4 security issues in this pull request:

Hard-Coded Secrets (4)
Severity Details Docs
Medium Title: Hex High Entropy String
source_hash = 482eed9efbc98388dbaee5cb5f368be5eca4893456bb358c18b7ff71f835ae43
📚
Medium Title: Hex High Entropy String
patch_hash = eee2e90d5d43061a0a1f0b9f8eb188c5b8820ef3e1b15e4b8a4eb791ef82b325
📚
Medium Title: Hex High Entropy String
source_hash = d9a15a42db7c78f88fe3d3c5945acce2f4bfe9e4da9f685cd19f6ea1d40aa884
📚
Medium Title: Hex High Entropy String
patch_hash = c871d65d019e55b372cb6c5878ed9cc496ab5c3ccfb56e4171ab2526970d49b2
📚

More info on how to fix Hard-Coded Secrets in General.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant