forked from MusicPlayerDaemon/MPD
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from MusicPlayerDaemon:master #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one will be pulled in by libnpupnp automatically. No need to have it here.
Homebrew comes with libnfs 6 which is not supported by MPD 0.23.
According to the yajl API documentation, #include lines should have the "yajl/" path prefix, but the actual pkg-config file contains: includedir=${dollar}{prefix}/include/yajl .. which already contains this directory name, and thus the "yajl/" prefix cannot work. Unfortunately, the yajl project hasn't been maintained for nearly 10 years, and there's little chance this bug will ever be fixed.
This yajl on Homebrew comes with broken headers: /opt/homebrew/Cellar/yajl/2.1.0/include/yajl/yajl_parse.h:22:10: fatal error: 'yajl/yajl_common.h' file not found #include <yajl/yajl_common.h> ^~~~~~~~~~~~~~~~~~~~
Reviewer's Guide by SourceryThis pull request updates the build system to correctly link dependencies and removes an unused subproject. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Update the build system to include the
event
dependency in thenfs
andcurl
libraries, and reorder thelibmpdclient
dependency in the main project file. Remove thelibmicrohttpd.wrap
file.Build:
event
dependency in thenfs
andcurl
libraries.libmpdclient
dependency in the main project file.libmicrohttpd.wrap
file.Chores:
.gitignore
file to thesubprojects
directory.