Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from MusicPlayerDaemon:master #21

Merged
merged 15 commits into from
Jan 28, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 28, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update the build system to include the event dependency in the nfs and curl libraries, and reorder the libmpdclient dependency in the main project file. Remove the libmicrohttpd.wrap file.

Build:

  • Include the event dependency in the nfs and curl libraries.
  • Reorder the libmpdclient dependency in the main project file.
  • Remove the libmicrohttpd.wrap file.

Chores:

  • Add a .gitignore file to the subprojects directory.

This one will be pulled in by libnpupnp automatically.  No need to
have it here.
Homebrew comes with libnfs 6 which is not supported by MPD 0.23.
According to the yajl API documentation, #include lines should have
the "yajl/" path prefix, but the actual pkg-config file contains:

 includedir=${dollar}{prefix}/include/yajl

.. which already contains this directory name, and thus the "yajl/"
prefix cannot work.  Unfortunately, the yajl project hasn't been
maintained for nearly 10 years, and there's little chance this bug
will ever be fixed.
This yajl on Homebrew comes with broken headers:

 /opt/homebrew/Cellar/yajl/2.1.0/include/yajl/yajl_parse.h:22:10: fatal error: 'yajl/yajl_common.h' file not found
 #include <yajl/yajl_common.h>
          ^~~~~~~~~~~~~~~~~~~~
@pull pull bot added the ⤵️ pull label Jan 28, 2025
@pull pull bot merged commit a5da7fd into CartoonFan:master Jan 28, 2025
Copy link

sourcery-ai bot commented Jan 28, 2025

Reviewer's Guide by Sourcery

This pull request updates the build system to correctly link dependencies and removes an unused subproject.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Switched the order of libmpdclient and libmicrohttpd in the meson build file.
  • Reordered the libmpdclient and libmicrohttpd dependencies in meson.build
meson.build
Added event_dep as a dependency to the nfs and curl libraries.
  • Added event_dep to the dependencies of the nfs library.
  • Added event_dep to the dependencies of the curl library.
  • Added event_dep to the dependencies of the nfs_dep dependency declaration
src/lib/nfs/meson.build
src/lib/curl/meson.build
Removed the libmicrohttpd subproject.
  • Removed the libmicrohttpd.wrap file.
  • Removed the libmicrohttpd entry from the .gitignore file in the subprojects directory
subprojects/.gitignore
subprojects/libmicrohttpd.wrap

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant