-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform R notebooks to Rmd; Add checks for R notebooks; Small mod to checks in Python notebooks #10
Conversation
…salAIBook/MetricsMLNotebooks into transform-R-notebooks-to-Rmd
…te .R files in PM1
…te .R files in CM2
…salAIBook/MetricsMLNotebooks into transform-R-notebooks-to-Rmd
Hi @vsyrgkanis I checked all generated Rmds in branch Also the liniting improves the coding style nicely.
The linting issues I could correct in the .irnb files so that next time the Rmds are generated they are fine too. However, they might be linted back next time the lint action runs. Maybe a small remark, if you render the Rmd to html, the title is "An R Markdown document converted from ..." which is maybe not super pretty but also not really an issue. I will check all upcoming notebooks as soon as they finished rendering on my machine. Is there anything else you would like me to look at? Best, |
Sorry for the reverted commit. Got confused since execution failed both locally and on colab and only then saw that keras < 3.0.0 is a dependency here. I was able to render all the Notebooks now and they look fine and are consistent with the irnb. |
Yes there was an issue with our code with Keras3 and beyond, so had to add this dependency. Otherwise we need to change a lot in our code, if we want to support keras3. |
Also @OliverSchacht @MartinSpindler one protocol is that approvers, just add comments and request to a PR and not directly make changes and pushes! |
This PR makes the following changes: