Feat/issue 163 - Attendee Profile photo and Name to be displayed in the suggestions #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ahnaf
reviewed
Jan 16, 2025
ali-ahnaf
reviewed
Jan 16, 2025
ali-ahnaf
reviewed
Jan 17, 2025
ali-ahnaf
reviewed
Jan 17, 2025
|
@piru72 what happens if a free form email is entered? does it show an image or name? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves : #163
How
Instead of only sending the
emailfrom the server now an object of{email, name, photos}are being sent to the client. Which renders the attendees suggestions.Screenshot