Skip to content

Commit

Permalink
Bubble docking adjustment (shiptest-ss13#2415)
Browse files Browse the repository at this point in the history
Adjust mobile docking port to ensure east facing, added stationary
docking port.

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

The Bubble lacked a docking port for shuttles, and would rotate in
flight.

Expanded map height (Y) by one to fit stationary dock. Added stationary
dock to south airlock for shuttle use:
![Weaver Lambda AB 2023-10-19
055811](https://github.com/shiptest-ss13/Shiptest/assets/14267245/0d8da4b2-a9f3-4de1-baf5-155ad3829a70)

Moved mobile dock to north pad and corrected `preferred_direction` (was
north!) and `port_direction`. This ensured east-facing during transit.

With the expanded map height (Y), Bubble map was now a square and would
land facing north. Expanded map length (X) to make it rectangular again,
and now it correctly lands facing east.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Shuttle docking adds options. Consistent ship facing prevents issues.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
tweak: Bubble now consistently faces east
add: added Bubble subshuttle dock
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
Doubleumc authored and Mirag1993 committed Nov 18, 2023
1 parent b767785 commit c23ebcd
Showing 1 changed file with 58 additions and 7 deletions.
65 changes: 58 additions & 7 deletions _maps/shuttles/independent/independent_bubble.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -650,13 +650,14 @@
/turf/open/floor/plasteel/mono,
/area/ship/hallway/central)
"AR" = (
/obj/machinery/door/airlock/external,
/obj/docking_port/mobile{
launch_status = 0;
port_direction = 4
/obj/docking_port/stationary{
width = 30;
height = 15;
dwidth = 15;
dir = 2
},
/turf/open/floor/plating,
/area/ship/engineering)
/turf/template_noop,
/area/space)
"AU" = (
/obj/machinery/cryopod{
dir = 4
Expand Down Expand Up @@ -955,6 +956,18 @@
},
/turf/open/floor/plating/rust,
/area/ship/maintenance/aft)
"Nf" = (
/obj/effect/turf_decal/industrial/warning{
dir = 1
},
/obj/docking_port/mobile{
launch_status = 0;
port_direction = 8;
preferred_direction = 4;
dir = 2
},
/turf/open/floor/plating,
/area/ship/external)
"NN" = (
/obj/structure/frame/computer{
dir = 4
Expand Down Expand Up @@ -1278,6 +1291,7 @@ VB
VB
VB
VB
VB
"}
(2,1,1) = {"
VB
Expand All @@ -1297,6 +1311,7 @@ VB
VB
VB
VB
VB
"}
(3,1,1) = {"
VB
Expand All @@ -1316,6 +1331,7 @@ VB
VB
VB
VB
VB
"}
(4,1,1) = {"
VB
Expand All @@ -1335,6 +1351,7 @@ Ob
VB
VB
VB
VB
"}
(5,1,1) = {"
VB
Expand All @@ -1354,6 +1371,7 @@ Ob
VB
VB
VB
VB
"}
(6,1,1) = {"
VB
Expand All @@ -1373,6 +1391,7 @@ nH
nH
VB
VB
VB
"}
(7,1,1) = {"
VB
Expand All @@ -1392,6 +1411,7 @@ KG
nH
VB
VB
VB
"}
(8,1,1) = {"
VB
Expand All @@ -1411,6 +1431,7 @@ eT
nH
VB
VB
VB
"}
(9,1,1) = {"
VB
Expand All @@ -1430,6 +1451,7 @@ fs
vR
xX
VB
VB
"}
(10,1,1) = {"
VB
Expand All @@ -1449,6 +1471,7 @@ kW
nH
NX
VB
VB
"}
(11,1,1) = {"
Xn
Expand All @@ -1468,9 +1491,10 @@ IL
Vt
Rk
MJ
VB
"}
(12,1,1) = {"
gl
Nf
Gl
ec
nS
Expand All @@ -1486,6 +1510,7 @@ cH
Ls
ZQ
cG
ZQ
AR
"}
(13,1,1) = {"
Expand All @@ -1506,6 +1531,7 @@ UC
Vt
mY
MJ
VB
"}
(14,1,1) = {"
VB
Expand All @@ -1525,6 +1551,7 @@ MJ
MJ
VB
VB
VB
"}
(15,1,1) = {"
VB
Expand All @@ -1544,6 +1571,7 @@ zy
VB
VB
VB
VB
"}
(16,1,1) = {"
VB
Expand All @@ -1563,6 +1591,7 @@ zy
VB
VB
VB
VB
"}
(17,1,1) = {"
VB
Expand All @@ -1582,6 +1611,7 @@ VB
VB
VB
VB
VB
"}
(18,1,1) = {"
VB
Expand All @@ -1601,4 +1631,25 @@ VB
VB
VB
VB
VB
"}
(19,1,1) = {"
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
VB
"}

0 comments on commit c23ebcd

Please sign in to comment.