Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Remove superfluous logic in revolver/rack() #774

Closed
wants to merge 1 commit into from

Conversation

MysticalFaceLesS
Copy link
Member

Оригинальный PR: shiptest-ss13#3127

About The Pull Request

I was reviewing revolver.dm and noticed a bit of duplicated logic.

While "twice to be sure" is usually a good idea for using a gun, it's probably not necessary here.

Why It's Good For The Game

Clean code is good code?

Changelog

🆑blinkdog
fix: Cleaned up some logic in revolver safety
/:cl:

@github-actions github-actions bot added 🪓 НЕ МОДУЛЬНО 🪓 Не мудульно да, переделать бы 🧱 Код 🧱 Изменения .dm файлов 🔵 Требуется проверка labels Jun 21, 2024
@MrCat15352 MrCat15352 added 🚧 Фикс багов 🚧 Фиксится какая-то проблема или баг ☠Слияние с ОФАМИ☠ PR говорит сам за себя. Подтягиваем последние обновы офов... Да хранит нас дядя Целадонский and removed 🪓 НЕ МОДУЛЬНО 🪓 Не мудульно да, переделать бы labels Jun 21, 2024
Copy link

Pull Request содержит конфликты. Устраните их, чтобы мы смогли оценить и принять запрос.

@MrCat15352 MrCat15352 closed this Jun 22, 2024
@MysticalFaceLesS MysticalFaceLesS deleted the upstream-pr-3127 branch June 30, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict ☠Слияние с ОФАМИ☠ PR говорит сам за себя. Подтягиваем последние обновы офов... Да хранит нас дядя Целадонский 🔵 Требуется проверка 🚧 Фикс багов 🚧 Фиксится какая-то проблема или баг 🧱 Код 🧱 Изменения .dm файлов
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants