Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InfoURL handling, use fmt >=10.1 for path formatting #2299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajtribick
Copy link
Collaborator

  • Validate protocol of InfoURL is http or https, otherwise treat as file path
  • Always convert file paths to absolute canonical file URLs
  • Ensure backslashes are converted to forward slashes in Windows file URLs
  • Warn if invalid URLs are detected
  • fmt introduced non-quoted path formatting in fmt 10.1, use it if available

- Validate protocol of InfoURL is http or https, otherwise treat as file path
- Always convert file paths to absolute canonical file URLs
- Ensure backslashes are converted to forward slashes in Windows file URLs
- Warn if invalid URLs are detected
- fmt introduced non-quoted path formatting in fmt 10.1, use it if available
@ajtribick ajtribick marked this pull request as ready for review February 25, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant