Support a single client connecting to multiple servers/processes #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. I will have a close look at its implications. Not to worry about processor timeline view, as long as it doesn't break. |
dwilliamson
reviewed
Aug 1, 2023
| case FOURCC('G', 'S', 'S', 'T'): { | ||
| Buffer* bin_buf = rmt->server->bin_buf; | ||
| WebSocket_PrepareBuffer(bin_buf); | ||
| bin_SamplesStart(bin_buf, rmt->timer.counter_start); |
There was a problem hiding this comment.
I don't know why any of the tests aren't picking this up, but this should be rmt->timer.counter_start.QuadPart.
|
I'm trying to test the processor view right now but it doesn't actually appear to be working on the laptop I'm testing on, so I may have to debug that first before I get any further with testing this. |
dwilliamson
requested changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses address patterns like
ws:/127.0.0.1:1781{5,6}/rmtto connect to multiple servers. Shows thread names with the0_,1_... prefixes depending on the server of origin. Sends console input to the first server.Added GSST and SSST messages for retrieving the starting timepoints from the servers.
Copy-pasted the https://github.com/juliangruber/balanced-match and https://github.com/juliangruber/brace-expansion to get the address pattern parsing.
Not sure if it works for the Processor Timelines.
Fixes #134