Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Vulkan sampling support #256

Merged
merged 28 commits into from
Jan 18, 2024
Merged

WIP: Vulkan sampling support #256

merged 28 commits into from
Jan 18, 2024

Commits on Jan 6, 2024

  1. WIP: First-pass implementation of Vulkan profiling. Currently assumes…

    … Vulkan 1.2 and/or a handful of extensions are available.
    Valakor committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    5d76b16 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dff750b View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Configuration menu
    Copy the full SHA
    11314f7 View commit details
    Browse the repository at this point in the history
  2. Fix rmt_ScopedD3D12Sample and rmt_ScopedVulkanSample. Extra parens co…

    …nfuse some compilers that think the end scope objects are function declarations
    Valakor committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    45f4887 View commit details
    Browse the repository at this point in the history
  3. Fix Remotery_Destructor when D3D12 or Vulkan sampling are enabled. Ne…

    …ed to clear g_Remotery only after calling _rmt_UnbindVulkan or _rmt_UnbindD3D12 since both functions access g_Remotery
    Valakor committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    e608550 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    067ba82 View commit details
    Browse the repository at this point in the history
  5. Update readme.md

    Valakor committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    433a90c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bf90e0d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fce6e3b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    533f7cf View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Configuration menu
    Copy the full SHA
    083be58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3db954d View commit details
    Browse the repository at this point in the history
  3. Update a handful of comments

    Valakor committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    bebb5a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5502716 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    90c8e2e View commit details
    Browse the repository at this point in the history
  6. Vulkan on MacOS (via MoltenVK) only allows query pools of up to size …

    …32k bytes, or 4k queries
    Valakor committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d41b2bf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6e3cbbf View commit details
    Browse the repository at this point in the history
  8. Fix timestamp calibration on MacOS. Turns out MoltenVK actually retur…

    …ns a timestamp in the mach_continuous_time() time domain instead of mach_absolute_time(), which I think is a bug
    Valakor committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    af38067 View commit details
    Browse the repository at this point in the history
  9. Update some comments in GetTimestampCalibration to reflect correct in…

    …formation w.r.t. MoltenVK/Vulkan. I'm close to convincing myself that I should drop querying the CPU timestamp entirely from Vulkan and just query it myself (like the Linux fallback does).
    Valakor committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6f957e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    8ceedd3 View commit details
    Browse the repository at this point in the history
  2. Clarify that the function pointer passed to rmt_BindVulkan is the vkG…

    …etInstanceProcAddr, not vkGetDeviceProcAddr
    Valakor committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f38c000 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c96a6f View commit details
    Browse the repository at this point in the history
  4. Update readme.md

    Valakor committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    53897b4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b0bf7c5 View commit details
    Browse the repository at this point in the history
  6. Cleaner shutdown by automatically consuming all pending GPU samples. …

    …Means the user doesn't have to do this themselves
    Valakor committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    70a13a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Configuration menu
    Copy the full SHA
    e7141d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Have the user specify Vulkan functions pointers instead of loading th…

    …em. Fix and update documentation
    Valakor committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2e56a7b View commit details
    Browse the repository at this point in the history
  2. Fix a handful of issues:

    1. Return RMT_ERROR_NONE instead of NULL from rmt_BindVulkan if Vulkan is not enabled
    2. Explicitly cast function pointers to void* in README since this is potentially required by some compilers
    3. Use rmtMakeError in rmt_BindVulkan to describe what parameter/function pointer is missing
    Valakor committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2f28ede View commit details
    Browse the repository at this point in the history