Skip to content

Commit

Permalink
Always explicitly reference STJ if the extension is used
Browse files Browse the repository at this point in the history
Relates to #277
  • Loading branch information
brantburnett committed Dec 13, 2024
1 parent a0f4556 commit f34ac28
Showing 1 changed file with 19 additions and 22 deletions.
41 changes: 19 additions & 22 deletions src/main/Yardarm.SystemTextJson/JsonDependencyGenerator.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using System.Collections.Generic;
using System.Collections.Generic;
using NuGet.Frameworks;
using NuGet.LibraryModel;
using NuGet.Versioning;
Expand All @@ -11,30 +10,28 @@ public class JsonDependencyGenerator : IDependencyGenerator
{
public IEnumerable<LibraryDependency> GetDependencies(NuGetFramework targetFramework)
{
if (targetFramework.Framework != NuGetFrameworkConstants.NetCoreApp || targetFramework.Version < new Version(9, 0))
{
// Only add System.Text.Json if we're not already targeting .NET 8
// Add System.Text.Json even if we're targeting .NET 9 to ensure we get bug fixes, especially for the source generator.
// This doesn't apply at the moment using 9.0.0, but it's a good practice to follow so we don't forget if we upgrade.

yield return new LibraryDependency
yield return new LibraryDependency
{
LibraryRange = new LibraryRange
{
LibraryRange = new LibraryRange
{
Name = "System.Text.Json",
TypeConstraint = LibraryDependencyTarget.Package,
VersionRange = VersionRange.Parse("9.0.0")
}
};
Name = "System.Text.Json",
TypeConstraint = LibraryDependencyTarget.Package,
VersionRange = VersionRange.Parse("9.0.0")
}
};

yield return new LibraryDependency
yield return new LibraryDependency
{
LibraryRange = new LibraryRange
{
LibraryRange = new LibraryRange
{
Name = "System.Net.Http.Json",
TypeConstraint = LibraryDependencyTarget.Package,
VersionRange = VersionRange.Parse("9.0.0")
}
};
}
Name = "System.Net.Http.Json",
TypeConstraint = LibraryDependencyTarget.Package,
VersionRange = VersionRange.Parse("9.0.0")
}
};
}
}
}

0 comments on commit f34ac28

Please sign in to comment.