Optimize schema type info for some common types #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- For common types like numbers and strings we're allocating more YardarmTypeInfo objects on the heap than necessary. We'd also like to get more clarity when a given type requires dynamic serialization as this may require additional support by serialization libraries. Modifications ------------- - For string and number types use shared static instances of YardarmTypeInfo - Obsolete the NullSchemaGenerator and replace with the DynamicSchemaGenerator which tracks it's parent element. This allows serialization extenions to recognize if the schema requires certain types of serialization support based on where it's located. - Add RequiresDynamicSerialization to YardarmTypeInfo and set to true for the DynamicSchemaGenerator
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For common types like numbers and strings we're allocating more YardarmTypeInfo objects on the heap than necessary. We'd also like to get more clarity when a given type requires dynamic serialization as this may require additional support by serialization libraries.
Modifications