-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6189] trovesearch denormalized #828
[ENG-6189] trovesearch denormalized #828
Conversation
d925cc4
to
b315c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks pretty good. A couple questions and some potential tidying, but no obvious bugs. Good test coverage.
Pass complete
index=self.indexname, | ||
) | ||
except elasticsearch8.TransportError as error: | ||
raise exceptions.IndexStrategyError() from error # TODO: error messaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: how annoying would it be to add error messaging instead of the TODOs
here and above?
ad5a52b
to
5378787
Compare
ff98360
to
28ece73
Compare
trovesearch_denorm
index strategy to speed up/trove/index-card-search
and/trove/index-value-search
requestsTROVESEARCH_DENORMILY
feature flag is upnested
fields (what a wild choice that was)cardSearchFilter
/cardSearchText
params, index additional docs for each iri value in an indexcard (each with a full copy of the card's filterable fields -- this is the denormalization part)and assorted improvements from meanderings in #824
IndexStrategy
with functions inshare.search.index_strategy
Elastic8IndexStrategy
to support indexing multiple docs per index-card (required for denormalization above)share.search.index_strategy._trovesearch_util