fix: retain entire iris in dynamic field names #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retain the entire iri for path-based field names -- this makes them easily reversible for highlighting fields that match (previously used "sufficiently unique" iris like "://foo.example/blarg", which works well enough, except it'd take knowledge to get the original) (bug introduced in 7b68b96 )
aaxelb
force-pushed
the
fix/highlight-path
branch
from
a0c2cda
to
9b23fad
Compare
mfraezz
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(trovesearch_denorm): whole-iris field names
retain the entire iri for path-based field names --
this makes them easily reversible for highlighting fields that match
(previously used "sufficiently unique" iris like "://foo.example/blarg",
which works well enough, except it'd take knowledge to get the original -- see e.g.
://purl.org/dc/terms/descriptionin search results' "Context" at https://staging.osf.io/search?q=miscellaneous )(bug introduced in 7b68b96 )