Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/finland old #1271

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Feature/finland old #1271

merged 14 commits into from
Oct 4, 2023

Conversation

BeritJanssen
Copy link
Contributor

Corpus definition for the debates of the pre 1905 Finnish parliament.

),
visualizations = ['resultscount', 'termfrequency']
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate.

Copy link
Contributor

@lukavdplas lukavdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 3 to 4
#### Language
Swedish and Finnish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit superfluous since it will be listed at the top of the page.

Copy link
Contributor

@lukavdplas lukavdplas Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use of adding these log settings on develop environments? (genuine question)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no logging whatsoever at this moment when indexing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice these settings were missing in the deployment module (https://github.com/UUDigitalHumanitieslab/deployment/issues/38), but this is settings.py, so it will not affect production. For development environments, I don't really see the use of an indexing log to be honest.

Copy link
Contributor Author

@BeritJanssen BeritJanssen Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary that this is a file logger indeed. I changed that. But it is definitely necessary to capture the logging from indexing, also during development.

@BeritJanssen BeritJanssen added this to the Next release milestone Oct 4, 2023
@BeritJanssen BeritJanssen merged commit b6caf95 into develop Oct 4, 2023
@BeritJanssen BeritJanssen deleted the feature/finland-old branch October 4, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants