-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/finland old #1271
Feature/finland old #1271
Conversation
), | ||
visualizations = ['resultscount', 'termfrequency'] | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
#### Language | ||
Swedish and Finnish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit superfluous since it will be listed at the top of the page.
backend/ianalyzer/settings.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use of adding these log settings on develop environments? (genuine question)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no logging whatsoever at this moment when indexing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did notice these settings were missing in the deployment module (https://github.com/UUDigitalHumanitieslab/deployment/issues/38), but this is settings.py
, so it will not affect production. For development environments, I don't really see the use of an indexing log to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary that this is a file logger indeed. I changed that. But it is definitely necessary to capture the logging from indexing, also during development.
Corpus definition for the debates of the pre 1905 Finnish parliament.