Feature/default sort #1501
Merged
Feature/default sort #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeltevanBoheemen
approved these changes
Mar 12, 2024
lukavdplas
added
frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the way that the default sort setting is represented. This is now a
default_sortattribute of the corpus, rather than an attribute of each field.This is a small preparation for importing the JSON definition in #1497 . It's not strictly necessary to import the JSON, but the frontend also stores the default sort configuration on the corpus rather than the field, so this update means there will be less conversion overall.
The field is provided as a string (in execution order,
default_sortmay be defined beforefields). There is no validation whether the field exists and is sortable - that depends on #1333