Run subprocesses through shell on Windows #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonggrijp
approved these changes
Dec 9, 2024
| # On Windows, we need to run the command through the shell to get | ||
| # access to commands in PATH. | ||
| exit_code = subprocess.call( | ||
| self.command, *self.args, **self.kwargs, shell=WINDOWS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly solves #48
Without
shell=True, almost every call ofsubprocess.call()fails on Windows; if I add it, (almost) everything works right out of the box.This will probably be hard to test for non-Windows users. I'm mainly concerned about the potential security risk mentioned on StackExchange.
Since we're using cookiecutter to set up a local project and all input is controlled, the risk of allowing arbitrary code execution seems very small.