Updates to vue3 templatetag for supporting Vite build #88
Conversation
| # read manifest json (based on vite output) | ||
| with open(settings.VUE_MANIFEST) as f: | ||
| manifest = json.load(f) |
There was a problem hiding this comment.
This only makes sense if you only have the one Vue app for the entire app; this will clash with the use-cases that DSC itself will encounter; (Multiple components, only some of which are useful for any given app).
Ideally, you can specify manifests in a more configurable way; in the Vue 2 app I build a 'app registry', which is just a simple class with info like this, grouped together under a single identifier one can use to load all you need. Something like that would be nicer
There was a problem hiding this comment.
What does vite do in that use case? Separate modules per component with separate manifests?
There was a problem hiding this comment.
In that case, there would be seperate (semi-)independent vite builds, so you would get separate manifests per 'app'.
For example, you get separate manifests for:
- The default List-view
- Any custom List-view
- Vue-powered form-widgets
| static = settings.STATIC_URL + 'vue/' | ||
| if hasattr(settings, 'VUE_URL'): | ||
| static = settings.VUE_URL |
There was a problem hiding this comment.
Why not use Django's built-in static resolving instead?
|
(To explain my registry thing a bit more) In this case would just be a simple singleton class, that is populated by adding a key-value to it in the |
See also UiL-OTS-labs/babex#121