validation + node rewards #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahortsaryk
approved these changes
Nov 10, 2023
yahortsaryk
reviewed
Nov 10, 2023
| let charge: BalanceOf<T> = amount.saturated_into::<BalanceOf<T>>(); | ||
|
|
||
| <T as pallet::Config>::Currency::transfer( | ||
| &updated_billing_report.vault, |
There was a problem hiding this comment.
Are we going to use a specific vault per each Billing Report that was generated as a sub-account? I thought we were about to start from a single Pallet's vault account. Did you confirm that sub-accounts are safe?
yahortsaryk
reviewed
Nov 10, 2023
| ChargingFinished { cluster_id: ClusterId, era: DdcEra }, | ||
| RewardingStarted { cluster_id: ClusterId, era: DdcEra }, | ||
| Rewarded { cluster_id: ClusterId, era: DdcEra, node_id: T::AccountId, amount: u128 }, | ||
| RewardingFinished { cluster_id: ClusterId, era: DdcEra }, |
There was a problem hiding this comment.
I think in the Rewarded event the field node_id should be renamed to node_provider_id or node_stash_id, as the reward is being received by the node operator.
As for node identifier (node_id), we use NodePublicKey type, which may be different from the one supported by T::AccountId and depends on DDC node's internal implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.