Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce clippy linter #92

Merged
merged 21 commits into from
Nov 10, 2023
Merged

Introduce clippy linter #92

merged 21 commits into from
Nov 10, 2023

Conversation

khssnv
Copy link
Member

@khssnv khssnv commented Sep 21, 2023

No description provided.

@khssnv khssnv force-pushed the feature/code-quality-clippy branch from 79f72f8 to ec63dda Compare September 22, 2023 08:51
MRamanenkau
MRamanenkau previously approved these changes Sep 25, 2023
View reviewed changes
@khssnv khssnv force-pushed the feature/code-quality-clippy branch from ec63dda to 3e90365 Compare September 25, 2023 09:52
Raid5594
Raid5594 reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@Raid5594 Raid5594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we update README as well?

@khssnv khssnv force-pushed the feature/code-quality-clippy branch 2 times, most recently from ddaf96b to 14b544f Compare October 23, 2023 11:14
@khssnv khssnv force-pushed the feature/code-quality-clippy branch from 14b544f to dd1d1bd Compare October 23, 2023 12:41
@khssnv khssnv force-pushed the feature/code-quality-clippy branch from dd1d1bd to 585f1d8 Compare October 24, 2023 06:48
@khssnv khssnv marked this pull request as draft October 24, 2023 11:23
@rakanalh
Copy link
Contributor

Shall we update README as well?

We don't have a CONTRIBUTE file yet so adding this to the read me would not have much value. Any dev making changes to the repo would need to cargo fmt and clippy check anyway and CI will also provide feedback after this PR.

@rakanalh rakanalh marked this pull request as ready for review November 10, 2023 11:51
@rakanalh rakanalh merged commit d346c19 into dev Nov 10, 2023
2 of 3 checks passed
@rakanalh rakanalh deleted the feature/code-quality-clippy branch November 10, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raid5594 Raid5594 Raid5594 approved these changes

@yahortsaryk yahortsaryk yahortsaryk approved these changes

@MRamanenkau MRamanenkau Awaiting requested review from MRamanenkau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khssnv @rakanalh @yahortsaryk @MRamanenkau @Raid5594