Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config inheritance Example #168

Open
wants to merge 9 commits into
base: cli-beta
Choose a base branch
from
Open

Config inheritance Example #168

wants to merge 9 commits into from

Conversation

nivcertora
Copy link
Contributor

@nivcertora nivcertora commented Apr 8, 2025 •
edited
Loading

@nivcertora nivcertora self-assigned this Apr 8, 2025
yoav-el-certora
yoav-el-certora previously requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@yoav-el-certora yoav-el-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing 2 cases from the ticket

@nivcertora
Copy link
Contributor Author

You are missing 2 cases from the ticket

This case is test not an example:
If there the base config has the attribute override_base_config, return an appropriate error.

yoav-el-certora
yoav-el-certora approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@yoav-el-certora yoav-el-certora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my point of view.
@urikirsh Do we want to present anything else here?

yoav-el-certora
yoav-el-certora reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@yoav-el-certora yoav-el-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nivcertora @rahav-certora Is there a reason why base.conf structure is different than new_fields.conf?

i.e all keys in base.conf and invalid_base.conf are wrapped with "" (like jsons) and new_fields.conf, override_fields.conf not?

@nivcertora
Copy link
Contributor Author

@nivcertora @rahav-certora Is there a reason why base.conf structure is different than new_fields.conf?

i.e all keys in base.conf and invalid_base.conf are wrapped with "" (like jsons) and new_fields.conf, override_fields.conf not?

Fixed

@nivcertora nivcertora requested a review from urikirsh April 10, 2025 17:51
urikirsh
urikirsh previously requested changes Apr 10, 2025
View reviewed changes
@nivcertora nivcertora requested a review from urikirsh April 10, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoav-el-certora yoav-el-certora yoav-el-certora approved these changes

@rahav-certora rahav-certora rahav-certora approved these changes

@nd-certora nd-certora Awaiting requested review from nd-certora

@urikirsh urikirsh Awaiting requested review from urikirsh

Assignees

@nivcertora nivcertora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nivcertora @urikirsh @rahav-certora @yoav-el-certora