-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal id option #63
Conversation
…dd-Proposal-id-option
…tora/Quorum into niv/CERT-7885-Add-Proposal-id-option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still comments from my previous review that you didn't address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes now that's great!
|
||
To run the tool, use the command line: | ||
**Purpose:** Generates a human-readable report of the proposal details, leveraging Jinja2 templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quorum summary for proposal validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the create_report subcommand need a fine tuning
https://certora.atlassian.net/browse/CERT-7885
PR Summary
This PR modernizes Quorum’s CLI architecture by consolidating the old standalone scripts (
check_proposal.py
, etc.) into a single entry point,Quorum
, with multiple subcommands:Additionally, the README has been updated to reflect these subcommands and removed references to the old
CheckProposal...
scripts. The workflow files (CI.yml
,publish-pypi.yml
) and the packaging config (pyproject.toml
, etc.) have also been updated accordingly, ensuring installation, publishing, and usage now align with this new unified CLI approach.