-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated JetBrains configuration for prettier #12428
Conversation
Thank you for the pull request, @weegeekps! Welcome to the Cesium community! In order for us to review your PR, please complete the following steps:
Review Pull Request Guidelines to make sure your PR gets accepted quickly. |
Thanks @weegeekps! @jjspace could you please review? |
Does the prettier integration not just respect the |
Prettier integration will turn on if it sees a |
.idea/prettier.xml
Outdated
<project version="4"> | ||
<component name="PrettierConfiguration"> | ||
<option name="myConfigurationMode" value="AUTOMATIC" /> | ||
<option name="myFilesPattern" value="**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts,vue,astro,html,xhtml}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, with the default settings, it won't run on .html files.
@weegeekps Can this be **/*
or just *
?
If not you should add css
and md
to the extension list.
I would've expected the extension to rely on the .prettierignore
file to dictate what it should and shouldn't run against. If it doesn't do this or if it only does the ignore check after this list of files then you need those extensions as well to match every file we normally lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, it's not advisable to use **/*
for performance reasons. I added css
and md
to the list of extensions in the glob pattern.
Description
This updates the IntelliJ/Webstorm/Clion/etc configuration used by JetBrains IDE projects to properly support prettier across the project.
Issue number and link
N/A
Testing plan
N/A
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change