Skip to content

Commit

Permalink
Minor cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
j9liu committed Oct 29, 2024
1 parent 2b387c0 commit 6dec236
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"$id": "glTF.KHR_implicit_shapes.shape.EXT_implicit_cylinder_region.schema.json",
"title": "EXT_implicit_cylinder_region extension on KHR_implicit_shapes.shape",
"type": "object",
"description": "`EXT_implicit_cylinder_region` extension on `KHR_implicit_shapes.shape` to represent an implicit cylinder region in a glTF model.",
"description": "Extension of `KHR_implicit_shapes.shape` to represent an implicit cylinder region in a glTF model.",
"allOf": [
{
"$ref": "glTFProperty.schema.json"
Expand Down
39 changes: 38 additions & 1 deletion extensions/2.0/Vendor/EXT_implicit_ellipsoid_region/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ The reference ellipsoid is centered at the origin. The `semiMajorAxisRadius` ind

The `semiMinorAxisRadius` indicates the radius of the ellipsoid in meters along the `y` axis.

The `minHeight` and `maxHeight` properties indicates the heights of the region from the ellipsoid's surface, in meters. The `minimum` height should be lower a value, but not necessarily closer to the surface of the ellipsoid. For example, `maxHeight` may be `10` while `minHeight` is `-100`.
The `minHeight` and `maxHeight` properties indicates the heights of the region from the ellipsoid's surface, in meters. The `minimum` height should be a lower value, but not necessarily lower in magnitude. For example, `maxHeight` may be `10` while `minHeight` is `-100`.

<table>
<tr>
Expand Down Expand Up @@ -60,5 +60,42 @@ The `minHeight` and `maxHeight` properties indicates the heights of the region f
</tr>
</table>

An ellipsoid region may also be confined to a specific latitude and/or longitude range. The `minLatitude` and `maxLatitude` properties represent the latitude values at which the region starts and stops, defined in the range `[-pi/2, pi/2]`. Similarly, the `minLatitude` and `maxLatitude` properties represent the longitude bounds within the range `[-pi, pi]`.

<table>
<tr>
<th>
Example
</th>
</tr>
<tr>
<td><pre>
"extensions": [
{
"KHR_implicit_shapes": {
"shapes": [
{
"type": "ellipsoid region",
"extensions": {
"EXT_implicit_ellipsoid_region": {
"semiMajorAxisRadius": 4,
"semiMinorAxisRadius": 2,
"minHeight": 0,
"maxHeight": 0.5,
// TODO
}
}
}
]
}
}
]
</pre></td>
<td>
**TODO** visual example
</td>
</tr>
</table>

## Optional vs. Required
This extension is required, meaning it should be placed in both the `extensionsUsed` list and `extensionsRequired` list.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"$id": "glTF.KHR_implicit_shapes.shape.EXT_implicit_ellipsoid_region.schema.json",
"title": "EXT_implicit_ellipsoid_region extension on KHR_implicit_shapes.shape",
"type": "object",
"description": "`EXT_implicit_ellipsoid_region` extension on `KHR_implicit_shapes.shape` to represent an implicit ellipsoid region in a glTF model. Useful for geospatial applications, such as Earth-conforming voxel data.",
"description": "Extension of `KHR_implicit_shapes.shape` to represent an implicit ellipsoid region in a glTF model.",
"allOf": [
{
"$ref": "glTFProperty.schema.json"
Expand Down

0 comments on commit 6dec236

Please sign in to comment.