Minor schema fixes for EXT_mesh_features revision
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since scalar, vector, and matrix types always contain numeric components the extra clarification may not actually be needed. In other words only those three types can define a componentType. https://github.com/CesiumGS/3d-tiles/tree/extension-revisions/specification/Metadata#component-type |
|
This PR is replaced by #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
propertyMappingproperty of a primitive is now an array, and thus, renamed topropertyMappingsThe
descriptionin the property schema formin/max/offset/scalenow mentions that these are only applicable when thecomponentTypeis numeric.(The analogous change for the latter in
3DTILES_metadatais in CesiumGS/3d-tiles#628 )