remove now redundant env set vars

ChainSafe · Mar 11, 2024 · 1148504 · 1148504
1 parent 91245f3
commit 1148504
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 20 deletions.
diff --git a/lightclient-circuits/src/aggregation_circuit.rs b/lightclient-circuits/src/aggregation_circuit.rs
@@ -16,7 +16,7 @@ use snark_verifier_sdk::{
     halo2::aggregation::{AggregationCircuit, AggregationConfigParams},
     Snark, SHPLONK,
 };
-use std::{env::set_var, fs::File, path::Path};
+use std::{fs::File, path::Path};
 
 /// Configuration for the aggregation circuit.
 #[derive(Clone, Debug, Default, Serialize, Deserialize)]
@@ -104,17 +104,9 @@ impl AppCircuit for AggregationCircuit {
         // We assume that `AggregationCircuit` will only be used for a single aggregation/compression layer.
         circuit.expose_previous_instances(false);
 
-        match stage {
-            CircuitBuilderStage::Prover => {
-                circuit.set_params(circuit_params);
-                circuit.set_break_points(pinning.map_or(vec![], |p| p.break_points));
-            }
-            _ => {
-                set_var(
-                    "AGG_CONFIG_PARAMS",
-                    serde_json::to_string(&circuit.calculate_params(Some(10))).unwrap(),
-                );
-            }
+        if matches!(stage, CircuitBuilderStage::Prover) {
+            circuit.set_params(circuit_params);
+            circuit.set_break_points(pinning.map_or(vec![], |p| p.break_points));
         };
 
         Ok(circuit)

diff --git a/lightclient-circuits/src/gadget/crypto/builder.rs b/lightclient-circuits/src/gadget/crypto/builder.rs
@@ -2,8 +2,6 @@
 // Code: https://github.com/ChainSafe/Spectre
 // SPDX-License-Identifier: LGPL-3.0-only
 
-use std::env::set_var;
-
 use crate::util::{CommonGateManager, Eth2ConfigPinning, GateBuilderConfig, Halo2ConfigPinning, PinnableCircuit};
 use eth_types::Field;
 use getset::Getters;
@@ -168,12 +166,7 @@ impl<F: Field, GateManager: CommonGateManager<F>> ShaCircuitBuilder<F, GateManag
     }
 
     pub fn calculate_params(&mut self, minimum_rows: Option<usize>) -> BaseCircuitParams {
-        let params = self.base.calculate_params(minimum_rows);
-        set_var(
-            "GATE_CONFIG_PARAMS",
-            serde_json::to_string(&params).unwrap(),
-        );
-        params
+        self.base.calculate_params(minimum_rows)
     }
 
     pub fn sha_contexts_pair(&mut self) -> (&mut Context<F>, GateManager::CustomContext<'_>) {