-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add forest-cli wait-api #5259
Conversation
echo "Forest RPC endpoint is unavailable - sleeping for 1s" | ||
sleep 1 | ||
done | ||
forest_wait_api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/cli/subcommands/wait_api_cmd.rs
Outdated
|
||
#[derive(Debug, clap::Args)] | ||
pub struct WaitApiCommand { | ||
/// duration to wait till fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to specify the input type (some examples?). Reading the description I am not sure if I should type --timeout 30
or --timeout 30s
or --timeout 0.5min
without going deeper into the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rock-solid
Co-authored-by: Hubert <[email protected]>
Summary of changes
This PR ports
lotus wait-api
to ForestChanges introduced in this pull request:
forest-cli wait-api
commandReference issue to close (if applicable)
Closes #5248
Other information and links
Change checklist