-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass execution requests as bytes to engine API #7145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensi321
force-pushed
the
nc/payload-engine-api
branch
from
October 10, 2024 05:28
17e0f59
to
7706848
Compare
ensi321
force-pushed
the
nc/payload-engine-api
branch
from
October 10, 2024 05:30
7706848
to
6b3205d
Compare
ensi321
commented
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nc/devnet-4 #7145 +/- ##
==============================================
Coverage ? 49.04%
==============================================
Files ? 596
Lines ? 39744
Branches ? 2069
==============================================
Hits ? 19494
Misses ? 20209
Partials ? 41 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
twoeths
reviewed
Oct 10, 2024
nflaig
approved these changes
Oct 10, 2024
ensi321
force-pushed
the
nc/payload-engine-api
branch
from
October 11, 2024 00:08
88c6a4f
to
a0c18e8
Compare
Merged
🎉 This PR is included in v1.23.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the latest change to the spec, execution requests are passed as bytes to
engine_newPayloadV4
, and EL will also return execution requests in bytes fromengine_getPayloadV4
.DATA[3]
, with deposit, withdrawal and consolidation requests rpc being the first, second and third element respectivelyDepositRequests
. Withdrawal and consolidation requests are in a similar fashionRelevant spec can be found in the following: