-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update form string from "user name" to "program name" #78
Open
seigot
wants to merge
14
commits into
ChallengeClub:dev
Choose a base branch
from
seigot:main
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
本番環境にフロントエンドをデプロイ
本番環境用main.tfの修正
評価実行ステータスのrowの色を青色に変更、試行回数カラムのデータ型を数値型に変更
frontendのdeployとterraformリソースの更新に関するCICDを分離させる
ランダムシードの指定機能を追加する
詳細ダイアログ表示機能追加
評価結果詳細ダイアログをrandom_seedsでiterationする
評価結果詳細を取得して表示する機能を追加する
結果詳細のテーブルのイテレーションを試行回数で回す
エラー時にはエラーメッセージを表示する
結果テーブルをソートした後でも正しく詳細ウィンドウを表示する
テキストウィジェットを選択可能に変更
formにファイルの存在をチェックする機能を追加
EndoNrak
reviewed
Mar 21, 2023
@@ -42,7 +42,7 @@ class EntryForm extends HookConsumerWidget { | |||
height: _formCardHeight, | |||
child: TextFormField( | |||
decoration: const InputDecoration( | |||
labelText: 'user name', | |||
labelText: 'program name', | |||
), | |||
controller: _userNameFormController, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
controllerも_programNameControllerとかに変更しておいてもらえると助かります!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.