New Task to create tunelo-calico network/subnet #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a task in the k3s playbook to create the tunelo-calico network and the tunelo-calico subnet that are both necessary for the management of hub and spoke ports and the proper functioning of tunelo.
msherman64
reviewed
Jun 17, 2024
| kolla_toolbox: | ||
| module_name: os_network | ||
| module_args: | ||
| auth: "{{ openstack_auth }}" |
There was a problem hiding this comment.
add project: "{{ keystone_admin_project }}"
msherman64
reviewed
Jun 17, 2024
|
|
||
| - name: Create tunelo-calico subnet | ||
| kolla_toolbox: | ||
| module_name: os_subnet |
There was a problem hiding this comment.
add project: "{{ keystone_admin_project }}"
msherman64
requested changes
Jun 21, 2024
There was a problem hiding this comment.
I would leave the "{{ physical_network_calico }}" and "{{ physical_network_tunelo }}" hardcoded for now.
I'll add templating for them when I refactor the post-deploy network creation, as it's not useful before then. (can't make two different flat networks on the same physnet, so need to template everything else)
Otherwise LGTM
JOUNAIDSoufiane
force-pushed
the
soufianej-tunelo-calico
branch
from
1e774ac to
85bb025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a task in the k3s playbook to create the tunelo-calico network and the tunelo-calico subnet that are both necessary for the management of hub and spoke ports and the proper functioning of tunelo.