Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check linting issues #12

Merged
merged 2 commits into from
Nov 9, 2024
Merged

fix: check linting issues #12

merged 2 commits into from
Nov 9, 2024

Conversation

Lyton505
Copy link
Collaborator

@Lyton505 Lyton505 commented Nov 7, 2024

npm run format was not running because a period was left out.

@Lyton505 Lyton505 marked this pull request as ready for review November 7, 2024 20:44
@Lyton505
Copy link
Collaborator Author

Lyton505 commented Nov 7, 2024

@lolitaroz it seems a period was left out of the format script so the workflow was always passing even with unformatted code commits

@Lyton505 Lyton505 requested a review from lolitaroz November 7, 2024 20:45
lolitaroz
lolitaroz approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@lolitaroz lolitaroz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this! can you run the linter on the files so that it passes the checks before you merge?

@Lyton505 Lyton505 merged commit 2b91e9d into main Nov 9, 2024
3 checks passed
@lolitaroz lolitaroz deleted the lyton/fix branch November 17, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolitaroz lolitaroz lolitaroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lyton505 @lolitaroz