Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tag-related logic for event signup #63

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Conversation

DavidHuang2002
Copy link
Collaborator

since now we are using tags only for events, remove tag-related logic for event sign-up since it is creating an error

Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bookem-user ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 6:43pm

Copy link
Collaborator

@zineanteoh zineanteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so essentially, our user documents no longer need to have the tags as a field, so we are removing any logic to add to user.tags.

lgtm! thx @DavidHuang2002 .

@zineanteoh zineanteoh merged commit 46c4b17 into main Nov 12, 2023
5 checks passed
@zineanteoh zineanteoh deleted the fix-event-sign-up branch November 12, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants