Dashboard fix #65
Merged
Dashboard fix #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -93,6 +93,18 @@ export const formatBirthday = (value: string) => { | |||
| )}`; | |||
| }; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Moved this to util module since it's a good helper function to reuse
JiashuHarryHuang
approved these changes
Nov 15, 2023
| @@ -0,0 +1,19 @@ | |||
| import { fetchData } from '@/utils/utils'; | |||
There was a problem hiding this comment.
Use a custom hook to avoid duplicate code.
| @@ -1,13 +1,18 @@ | |||
| import React from 'react'; | |||
| import Image from 'next/image'; | |||
| import { useEffect, useState } from 'react'; | |||
There was a problem hiding this comment.
We only need username here so using session data would be enough
| @@ -27,48 +30,58 @@ import { | |||
| * dollarsDonated: number; | |||
| * } | |||
| */ | |||
| const MainDashboard = ({ userData }: any) => { | |||
| const MainDashboard = ({ userData }: { userData: QueriedUserData | null }) => { | |||
There was a problem hiding this comment.
Avoid using "any" type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the hard coded user information on main dashboard to real user data.
Modified
index.tsxto fetch user data from mongodb by callingindex.ts.Modified
userIcon.tsxto match the user name with the fetched user data.Changed the information displayed on home. Modified
MainDashboard.tsxto show the user's events volunteered and date joined.Make the infoIcon on home page clickable. Modified
MainDashboard.tsx's content inside InfoIcon.