Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile pic upload #79

Merged
merged 15 commits into from
Feb 11, 2024
Merged

Profile pic upload #79

merged 15 commits into from
Feb 11, 2024

Conversation

ShoggyR79
Copy link
Collaborator

Solved a few merge conflicts and add profile image url to session
image

Copy link

vercel bot commented Feb 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bookem-user ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2024 5:54am

@JiashuHarryHuang JiashuHarryHuang linked an issue Feb 4, 2024 that may be closed by this pull request
4 tasks
@huongthaoh
Copy link
Collaborator

Screenshot 2024-02-04 at 4 15 14 PM

instead of using getSignedUrl to get file from S3, can accessing file directly using bucketname + region + fileName.

Copy link
Collaborator

@JiashuHarryHuang JiashuHarryHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make upload image a required step for registration? Currently, if a user finishes registration, he is not able to see his profile immediately after signing up.
image

After sign out and sign in:
image

@ShoggyR79
Copy link
Collaborator Author

Can you make upload image a required step for registration? Currently, if a user finishes registration, he is not able to see his profile immediately after signing up. image

After sign out and sign in: image

image is now available in first load. Switch to pulling user data instead of pulling from session. Might be a performance impact but no work around is there since image uploading is after the initial 5 steps.

I think you shouldnt force a user to upload an image. perhaps consider the default image route.

@JiashuHarryHuang
Copy link
Collaborator

Can you make upload image a required step for registration? Currently, if a user finishes registration, he is not able to see his profile immediately after signing up. image
After sign out and sign in: image

image is now available in first load. Switch to pulling user data instead of pulling from session. Might be a performance impact but no work around is there since image uploading is after the initial 5 steps.

I think you shouldnt force a user to upload an image. perhaps consider the default image route.

Ok I'll merge it for now and then talk to Book'em whether they want it to be a required step or not. Thanks for the good work!

Copy link
Collaborator

@JiashuHarryHuang JiashuHarryHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JiashuHarryHuang JiashuHarryHuang merged commit fc1dbc1 into main Feb 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picture Upload
3 participants