fix(handle_regular_status_updates) Stops body build changing for synthetics and undead #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📜 Требуется CL
Doster-d
reviewed
Oct 4, 2023
| change_body_build(new_body_build) | ||
| to_chat(src, SPAN("warning", "You've [nutrition_problem == OVEREATING ? "gained" : "lost"] some weight!")) | ||
| nutrition_problem = FALSE | ||
| if(!isSynthetic(src) && !isundead(src)) |
There was a problem hiding this comment.
Думаю ты это хотел написать. ИЛИ вместо И
Suggested change
| if(!isSynthetic(src) && !isundead(src)) | |
| if(!isSynthetic(src) || !isundead(src)) |
There was a problem hiding this comment.
И вообще не плоди nesting conditions
Suggested change
| if(!isSynthetic(src) && !isundead(src)) | |
| if(isSynthetic(src) || isundead(src)) | |
| return |
There was a problem hiding this comment.
А это точно не сломает половину билда?
There was a problem hiding this comment.
Так ИЛИ это же только если потом ретерн будет стоять, так что в данном контексте И нужно. А чтобы так ретерн поставить надо же переставлять весь лайф таким образом, чтобы оно не сломало ниче лишнее.
github-actions
bot
added
📜 Есть CL
Moscowchief
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Синты не голодают.
fix #10635
Чейнджлог