Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(events): null ref to apc when electrical storm ends #10734

Merged
merged 3 commits into from
Nov 3, 2023
Merged

fix(events): null ref to apc when electrical storm ends #10734

merged 3 commits into from
Nov 3, 2023

Conversation

kreeperHLC
Copy link
Contributor

Занулять рефы круто

Чейнджлог 
🆑
bugfix: Рефы к АПЦ зануляются после конца электрического шторма.
/🆑
  • Pull Request полностью завершен, мне не нужна помощь чтобы его закончить.
  • Я внимательно прочитал все свои изменения и багов в них не нашел.
  • Я запускал сервер со своими изменениями локально и все протестировал.
  • Я ознакомился c Guide to Contribute.

@kreeperHLC kreeperHLC added the 🔧 фикс Фикс пофикшенного фикса label Oct 18, 2023
@kreeperHLC kreeperHLC requested a review from a team as a code owner October 18, 2023 11:00
@github-actions github-actions bot added the 📜 Есть CL Чейнджлог в наличии и не содержит ошибок label Oct 18, 2023
Zert0X
Zert0X previously approved these changes Oct 27, 2023
View reviewed changes
TobyThorne
TobyThorne reviewed Oct 30, 2023
View reviewed changes
code/datums/events/electrical_storm.dm Outdated
@@ -92,6 +92,7 @@
set_next_think(world.time + 3 SECONDS)

/datum/event/electrical_storm/proc/end()
valid_apcs = list()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а шо не valid_apcs.Cut()

@igorsaux igorsaux merged commit 9df3985 into ChaoticOnyx:dev Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobyThorne TobyThorne TobyThorne left review comments

@Tsurupeta Tsurupeta Tsurupeta left review comments

@igorsaux igorsaux igorsaux approved these changes

@Zert0X Zert0X Zert0X approved these changes

Assignees
No one assigned
Labels
📜 Есть CL Чейнджлог в наличии и не содержит ошибок 🔧 фикс Фикс пофикшенного фикса
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kreeperHLC @Tsurupeta @Zert0X @TobyThorne @igorsaux