-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial experimental Twitch Eventsub support #5837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
9f06d46
to
785dda0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
some date::parse issue
start is now createConnection, which can be run multiple times
Close open EventSub connections on exit Helix function to create subscriptions now accepts a SubscriptionRequest Added a debugger for SubscriptionRequest Added a `SubscriptionHandle` that can/will be able to take care of unsubscriptions from topics once no one is interested in them anymore. They're meant to work like scoped signal connections, where the dtor of the handle is what spits lowers the reference count of the "topic". There's a bad subscription for `channel.ban` in TwitchChannel atm, but it's being used to test subscription handles and errors in permissions
636a26a
to
cda0d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds initial Twitch EventSub support - it does not attempt to replace any current functionality provided by PubSub, but rather it attempts to provide an opt-in base for us to collaborate on going forward.
A few things have been left in the
TODO.md
file that are "known issues"