-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setHighlightSounds
& openSubscriptionPage
split hotkeys
#5856
Open
brian6932
wants to merge
2
commits into
Chatterino:master
Choose a base branch
from
brian6932:feat/mute-subscribe-bind
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c72b2d1
to
ff45e7a
Compare
setHighlightSounds
& subscribe
split bindssetHighlightSounds
& subscribe
split hotkeys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
ff45e7a
to
c21e03f
Compare
Nerixyz
reviewed
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The few unrelated changes could be done in another PR (possibly combined with passing hotkey arguments as const&
).
9f43f7e
to
cb5e20b
Compare
setHighlightSounds
& subscribe
split hotkeyssetHighlightSounds
& openSubscriptionPage
split hotkeys
cb5e20b
to
cc69c0f
Compare
cc69c0f
to
21c8f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these hotkeys were missing from the split header context menu entries, so added them. I didn't add any default binds, wasn't sure if they'd be wanted (e.g. CTRL+M for a
setHighlightSounds
toggle).