Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setHighlightSounds & openSubscriptionPage split hotkeys #5856

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brian6932
Copy link
Contributor

@brian6932 brian6932 commented Jan 26, 2025

I noticed these hotkeys were missing from the split header context menu entries, so added them. I didn't add any default binds, wasn't sure if they'd be wanted (e.g. CTRL+M for a setHighlightSounds toggle).

@brian6932 brian6932 force-pushed the feat/mute-subscribe-bind branch from c72b2d1 to ff45e7a Compare January 26, 2025 06:12
@brian6932 brian6932 changed the title feat: setHighlightSounds & subscribe split binds feat: setHighlightSounds & subscribe split hotkeys Jan 26, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/splits/Split.cpp Outdated Show resolved Hide resolved
src/widgets/splits/Split.cpp Show resolved Hide resolved
@brian6932 brian6932 force-pushed the feat/mute-subscribe-bind branch from ff45e7a to c21e03f Compare January 26, 2025 06:34
Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The few unrelated changes could be done in another PR (possibly combined with passing hotkey arguments as const&).

src/controllers/hotkeys/ActionNames.hpp Outdated Show resolved Hide resolved
src/singletons/Settings.hpp Outdated Show resolved Hide resolved
src/widgets/splits/Split.cpp Outdated Show resolved Hide resolved
src/widgets/splits/SplitHeader.cpp Outdated Show resolved Hide resolved
src/widgets/splits/SplitHeader.cpp Outdated Show resolved Hide resolved
@brian6932 brian6932 force-pushed the feat/mute-subscribe-bind branch from 9f43f7e to cb5e20b Compare January 26, 2025 15:35
@brian6932 brian6932 changed the title feat: setHighlightSounds & subscribe split hotkeys feat: setHighlightSounds & openSubscriptionPage split hotkeys Jan 26, 2025
@brian6932 brian6932 force-pushed the feat/mute-subscribe-bind branch from cb5e20b to cc69c0f Compare January 26, 2025 16:20
@brian6932 brian6932 force-pushed the feat/mute-subscribe-bind branch from cc69c0f to 21c8f56 Compare January 31, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants